search

SemanticMediaWiki / Mermaid

Provides a parser function to generate diagrams and flowcharts with the help of the mermaid script language
https://www.mediawiki.org/wiki/Extension:Mermaid
Other
36 stars 22 forks source link

Update mermaidjs to 8.10.2 #69

Closed LordAro closed 2 years ago

LordAro commented 3 years ago

Mermaidjs has fallen behind quite a bit. This updates it to the latest release. All I did was run yarn install as per instructions, and commit the results.

Would be nice to get a new (composer/packagist) release out of this too :)

I've also added a bit of a hack in for the travis ci failures - pins composer version to v1, so that older mediawiki's are still installable. Could probably do better, but it works well enough for this PR.

kghbln commented 3 years ago

Cool. We have to note though that this pull drops support for MediaWiki 1.34 and lower due to the switch to Composer 2

gesinn-it-gea commented 3 years ago

@kghbln ... where do you get that Composer 2 is now required? Did I miss something? Travis has been pinned to Composer 1 as far as I can see from a quick review.

kghbln commented 3 years ago

I got this from the code change to "install-mediawiki.sh" where the --1 flag was removed. If this does not result in Composer 2 being installed that I was wrong otherwise you indeed missed something. Anyhow next release should drop PHP 7.0 and 7.1 as well as MW 1.33 and 1.34. All of them: EOL.

gesinn-it-gea commented 3 years ago

@kghbln --1 was added, not removed https://github.com/SemanticMediaWiki/Mermaid/pull/69/files#diff-702ef9c3e7f959b500ff3499282a61439d05f1d7b96d04b19ad9d40b0318fb51R28

kghbln commented 3 years ago

Ah, senior moments. :) Still not really required I believe.

LordAro commented 3 years ago

It shouldn't be required for newer Mediawiki versions, no

LordAro commented 2 years ago

Closing this in favour of #88