search

SemanticMediaWiki / Mermaid

Provides a parser function to generate diagrams and flowcharts with the help of the mermaid script language
https://www.mediawiki.org/wiki/Extension:Mermaid
Other
36 stars 22 forks source link

Tests: Using assertContains() with string haystacks is deprecated #90

Open gesinn-it-gea opened 2 years ago

gesinn-it-gea commented 2 years ago

Using assertContains() with string haystacks is deprecated and will not be supported in PHPUnit 9. Refactor your test to use assertStringContainsString() or assertStringContainsStringIgnoringCase() instead.

See CI output for examples.

malberts commented 2 years ago

There's a trait you can add. I did this for SRF: https://github.com/SemanticMediaWiki/SemanticResultFormats/commit/054e4825d83212a6e820b11ca86959fd3a4948dc

gesinn-it-gea commented 2 years ago

@malberts thanks for the hint! This issue was more meant as a heads-up for future work...