SemanticMediaWiki / SemanticApprovedRevs

Complementary extension to Semantic MediaWiki and Approved Revs to control the storage of approved revision content
Other
4 stars 3 forks source link

SAR properties do not have a label in #ask results #15

Open hexmode opened 4 years ago

hexmode commented 4 years ago

Setup and configuration

Issue

The labels for SAR properties do not have a label in #ask results.

hexmode commented 4 years ago

I wonder if this is because I'm importing data from a 1.27 wiki. update.php is definitely run, but maybe I'm missing updateData.php.

kghbln commented 4 years ago

I wonder if this is because I'm importing data from a 1.27 wiki. update.php is definitely run, but maybe I'm missing updateData.php.

If you import data into a wiki you should indeed rebuild the data.

SAR and SESP properties not updating until purge

I do not yet have experience with SAR but I know that SESP automatically updates when you hit save with no need to purge. I would think that SAR does the same.

hexmode commented 4 years ago

If you import data into a wiki you should indeed rebuild the data.

And I thought I had, but I'm still working on automating my process so I can make sure these things happen reliably. So I've updated my process and am re-running it now.

kghbln commented 4 years ago

After rebuilding the data everything appears to be cool ...

kghbln commented 4 years ago

I guess this worked out after the data rebuild.

hexmode commented 4 years ago

Actually, this should probably be re-opened since a user is complaining about (mainly) SAR properties not propagating. I just put the 3.1.x release into production this week, which is the reason I'm only now getting the complaint.

kghbln commented 4 years ago

So it did not work out after a data rebuild. Not sure if this is an SMW or SAR problem. If it is the latter we can still move the issue over.

hexmode commented 4 years ago

There is a problem with both SAR and SESP properties. SAR property values are not shown and labels are not shown. SESP properties have labels, but the values do not show.

For example, I have the following wikitext on my user page:

<pre>{{#ask:
[[{{FULLPAGENAME}}]]
|?Approved revision
|?Approval status
|?Approved by
|?Approved date 
|?Modification date
}}
</pre>
{{#ask:
[[{{FULLPAGENAME}}]]
|?Approved revision
|?Approval status
|?Approved by
|?Approved date 
|?Modification date
}}
<pre>
{{#ask:
[[{{FULLPAGENAME}}]]
|?Page creator
|?Page author
}}
</pre>
{{#ask:
[[{{FULLPAGENAME}}]]
|?Page creator
|?Page author
}}

resulting in this page: image

hexmode commented 4 years ago

Browse wiki of the page: image

hexmode commented 4 years ago

Note that purging of page makes no difference.

jaideraf commented 4 years ago

@hexmode Did you use $sespgEnabledPropertyList? [0]:

[0] https://github.com/SemanticMediaWiki/SemanticExtraSpecialProperties/blob/master/docs/configuration.md

hexmode commented 4 years ago

Rolling back to SESP 2.1.0 (on my test wiki) and removing SAR produces labels, at least: image @jaideraf I had a typo in the name (back on my prod wiki) for $sespgEnabledPropertyList, but fixing that didn't change the SAR properties. The SESP properties appeared

jaideraf commented 4 years ago

Note that you have to run the "update.php" maintenance script from your wiki's base directory after setting this parameter for the required tables to be created.

@hexmode I assuming you did that, right?

jaideraf commented 4 years ago

Maybe you want to see this, too: https://github.com/SemanticMediaWiki/SemanticExtraSpecialProperties/blob/master/docs/migration-to-200.md

hexmode commented 4 years ago

Running update did make the SESP property values appear. SAR is still a problem -- no labels or values.

hexmode commented 4 years ago

Maybe you want to see this, too: https://github.com/SemanticMediaWiki/SemanticExtraSpecialProperties/blob/master/docs/migration-to-200.md

I did read that. It didn't stop me from making a typo, but I read it.

jaideraf commented 4 years ago

Not sure if this is an SMW or SAR problem. If it is the latter we can still move the issue over.

@kghbln now you can move the issue to SemanticApprovedRevs :wink:

hexmode commented 4 years ago

Ok, the SESP and SAR properties are working except that the SAR properties do not have a label this time... at least when I'm not doing queries on {{FULLPAGENAME}}: image

hexmode commented 4 years ago

Thank you, @jaideraf, for kindly bopping me over the head. :smile:

BUT I STILL FOUND A BUG! :man_dancing:

kghbln commented 4 years ago

I cannot leave you a day alone. Heaps of action here. :)

Thanks for narrowing down the issue. Yeah, I will move this over to SAR.