Support extension.json, SBL 2.0.0

SemanticMediaWiki / SemanticBreadcrumbLinks

Provides in-page navigation by building breadcrumb links from an attributive property filter.

https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Breadcrumb_Links

Other

16 stars 5 forks source link

Support extension.json, SBL 2.0.0 #52

Closed mwjames closed 6 years ago

mwjames commented 6 years ago

This PR is made in reference to:

This PR addresses or contains:

Adds support for extension.json and hereby makes wfLoadExtension( "SemanticBreadcrumbLinks" ); a necessary setting
Switches to 2.0.0 as version
Example of moving settings and create deprecated notice $GLOBALS['smwgDeprecationNotices']['sbl'] (see https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/3438)
- egSBLBreadcrumbTrailStyleClass -> sblgBreadcrumbTrailStyleClass

This PR includes:

[ ] Tests (unit/integration)
[x] CI build passed

kghbln commented 6 years ago

@mwjames I guess this one may be merged?!

mwjames commented 6 years ago

@mwjames I guess this one may be merged?!

I think it should be merged after SBL 1.5 has been released. Also, the PR contains an example of the settings renaming which should be continued before 2.0.

On 9/17/18, Karsten Hoffmeyer notifications@github.com wrote:

@mwjames I guess this one may be merged?!

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticBreadcrumbLinks/pull/52#issuecomment-421914910

kghbln commented 6 years ago

I think it should be merged after SBL 1.5 has been released. Also, the PR contains an example of the settings renaming which should be continued before 2.0.

Ah, ok. I misunderstood. So basically the existing code should go out to the public as 1.5.0 and after that we do 2.0.0 etc. starting with this pull. Fair enough I guess.

mwjames commented 6 years ago

Ah, ok. I misunderstood. So basically the existing code should go out to the public as 1.5.0 and after that we do 2.0.0 etc.

So I thought since it contains the support for MW 1.30+.

On 9/17/18, Karsten Hoffmeyer notifications@github.com wrote:

I think it should be merged after SBL 1.5 has been released. Also, the PR contains an example of the settings renaming which should be continued before 2.0.

Ah, ok. I misunderstood. So basically the existing code should go out to the public as 1.5.0 and after that we do 2.0.0 etc.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticBreadcrumbLinks/pull/52#issuecomment-422021932

kghbln commented 6 years ago

So I thought since it contains the support for MW 1.30+.

Good. Let's do it like this.

kghbln commented 6 years ago

@mwjames I guess this can be merged now. :)

kghbln commented 6 years ago

@mwjames Thanks a lot. I will release this as SBL 2.0.0 (https://github.com/SemanticMediaWiki/SemanticBreadcrumbLinks/issues/53) once SMW 3.0.0 is out.