SemanticMediaWiki / SemanticCite

Allows to manage citation resources using semantic annotations
https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Cite
Other
24 stars 13 forks source link

Replace usages of deprecated wfWikiID() #105

Closed Func86 closed 9 months ago

Func86 commented 2 years ago

The global function wfWikiID() is hard deprecated since 1.38, and its usages should be replaced with WikiMap::getCurrentWikiId().

This PR addresses or contains:

This PR includes:

krabina commented 1 year ago

When I checkout your version, I get the following

Fatal error: Uncaught UnexpectedValueException: callback 'SemanticCite::initExtension' is not callable in includes/registration/ExtensionRegistry.php:525
Stack trace:
#0 includes/registration/ExtensionRegistry.php(279): ExtensionRegistry->exportExtractedData()
#1 includes/Setup.php(278): ExtensionRegistry->loadFromQueue()
#2 maintenance/doMaintenance.php(83): require_once('/home/knowledge...')
#3 maintenance/update.php(312): require_once('/home/knowledge...')
#4 {main}
  thrown in includes/registration/ExtensionRegistry.php on line 525
kizule commented 9 months ago

This is already done in https://github.com/SemanticMediaWiki/SemanticCite/pull/116 by @thomas-topway-it, so I think that this PR can be closed.