search

SemanticMediaWiki / SemanticCite

Allows to manage citation resources using semantic annotations
https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Cite
Other
24 stars 13 forks source link

Not compatible with SWM 4.0.0 #107

Closed kghbln closed 9 months ago

kghbln commented 2 years ago

Setup and configuration

Issue

After upgrading to SMW 4.0.0 the SemanticCite extension no longer works. Annotations with [[CiteRef::CitationKey]] no longer render as expected, i.e. as a citation marker[1], instead a link to the CitationKey page is shown.

krabina commented 2 years ago

also the {{#scite:}} parser function does not work as if the extension was not installed. It shows in Special:Version, though.

grafik

z929669 commented 1 year ago

I'm currently updating a SMW wiki and running into issues.

Installed Semantic Media Wiki 4.1, and Composer complained that Semantic Cite 2.1 depends on SMW ~3.0. To get around this, I'm using Semantic Cite dev-master. I'm guessing this extension is still working out kinks with SMW 4.x, but here's the error on update.php:

PHP Fatal error:  Uncaught Error: Undefined constant "CACHE_ANYTHING" in /srv/sites/_wiki/extensions/SemanticCite/DefaultSettings.php:45
Stack trace:
#0 /srv/sites/_wiki/extensions/SemanticCite/SemanticCite.php(33): require_once()
#1 /srv/sites/_wiki/extensions/SemanticCite/SemanticCite.php(12): SemanticCite::load()
#2 /srv/sites/_wiki/vendor/composer/autoload_real.php(45): require('...')
#3 /srv/sites/_wiki/vendor/composer/autoload_real.php(49): {closure}()
#4 /srv/sites/_wiki/vendor/autoload.php(25): ComposerAutoloaderInit_mediawiki_vendor::getLoader()
#5 /srv/sites/_wiki/includes/AutoLoader.php(327): require_once('...')
#6 /srv/sites/_wiki/includes/Setup.php(114): require_once('...')
#7 /srv/sites/_wiki/maintenance/doMaintenance.php(83): require_once('...')
#8 /srv/sites/_wiki/maintenance/update.php(312): require_once('...')
#9 {main}
  thrown in /srv/sites/_wiki/extensions/SemanticCite/DefaultSettings.php on line 45

The line in question is: $GLOBALS['scigMetadataResponseCacheType'] = CACHE_ANYTHING;

krabina commented 1 year ago

See #110

krabina commented 1 year ago

Should be fixed with #116. If not, feel free to reopen.

krabina commented 12 months ago

Reopening. Just tried to add SemanticCite to a MW 1.39 installation and got the Uncaught Error: Undefined constant "CACHE_ANYTHING" error again. So it is not fixed.

z929669 commented 12 months ago

Reopening. Just tried to add SemanticCite to a MW 1.39 installation and got the Uncaught Error: Undefined constant "CACHE_ANYTHING" error again. So it is not fixed.

Thank you for noticing this. I was just about to post likewise on #116

kghbln commented 12 months ago

Once you are ready with the compatibility issues, please, create a task for making a new release and ping me. I will publish a new release and tag it.

@krabina @kizule @thomas-topway-it

kghbln commented 12 months ago

Ah, now I see all the rest. From #119 I get that this issue was fixed. @kizule Once you have done the CI please ping me and I will tag.

krabina commented 12 months ago

I don't see how #119 shoud fix the undefined constant error?

krabina commented 12 months ago

Just tried latest dev-master. Undefined constant error is still there. Must be fixed before we do a 3.x release.

krabina commented 12 months ago

What I find odd is how installing Semantic Cite completely breaks the wiki due to this error even if it is not enabled ein LocalSettings.php.