Closed thomas-topway-it closed 9 months ago
Fixes #110 and #107
Can we get this merged please? :) @jeroendedauw
Did you try it out and can confirm it is working? It is certainly working in our wikis.
Yes, I can. :)
If compatibility issues should be resolved now for SMW ~4.0, then please update likewise at packagist.org. The current (outdated?) SMW constraint (mediawiki/semantic-media-wiki: ~3.0) forces me to use Semantic Cite dev-master as a workaround ... installing Semantic Media Wiki 4.1.2, and Composer complained that Semantic Cite 2.1 depends on SMW ~3.0.
@JeroenDeDauw I guess we need your help here. The PR seems to be working fine, but I don't know about the dependency topics also mentioned in #113
Oh. If I understand correctly this it more about making a new release so people don't have to use the dev-master, because #113 is solved already.
Oh. If I understand correctly this it more about making a new release so people don't have to use the dev-master, because #113 is solved already.
Yes, this is what I meant. I did go ahead and use dev-master with the latest merge of this patch, but I do still get the CACHE_ANYTHING error as described in #107 and #113
Indeed, you need a new release
Here is what to do: https://github.com/SemanticMediaWiki/SemanticCite/issues/118
Ensures SemanticCite is compatible with MW1.39 / SWM 4.0.0
Fixes the following:
$GLOBALS
wfWikiID
onoi/http-request
getNextRevisionID
/getPreviousRevisionID
inMediaWikiContextInteractor
wfReadOnly
MediaWikiContextInteractorTest