SemanticMediaWiki / SemanticCite

Allows to manage citation resources using semantic annotations
https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Cite
Other
24 stars 13 forks source link

SemanticCite MW1.39 / SWM 4.0.0 compatible #116

Closed thomas-topway-it closed 9 months ago

thomas-topway-it commented 11 months ago

Ensures SemanticCite is compatible with MW1.39 / SWM 4.0.0

Fixes the following:

krabina commented 11 months ago

Fixes #110 and #107

kizule commented 9 months ago

Can we get this merged please? :) @jeroendedauw

krabina commented 9 months ago

Did you try it out and can confirm it is working? It is certainly working in our wikis.

kizule commented 9 months ago

Yes, I can. :)

z929669 commented 9 months ago

If compatibility issues should be resolved now for SMW ~4.0, then please update likewise at packagist.org. The current (outdated?) SMW constraint (mediawiki/semantic-media-wiki: ~3.0) forces me to use Semantic Cite dev-master as a workaround ... installing Semantic Media Wiki 4.1.2, and Composer complained that Semantic Cite 2.1 depends on SMW ~3.0.

krabina commented 9 months ago

@JeroenDeDauw I guess we need your help here. The PR seems to be working fine, but I don't know about the dependency topics also mentioned in #113

krabina commented 9 months ago

Oh. If I understand correctly this it more about making a new release so people don't have to use the dev-master, because #113 is solved already.

z929669 commented 9 months ago

Oh. If I understand correctly this it more about making a new release so people don't have to use the dev-master, because #113 is solved already.

Yes, this is what I meant. I did go ahead and use dev-master with the latest merge of this patch, but I do still get the CACHE_ANYTHING error as described in #107 and #113

JeroenDeDauw commented 9 months ago

Indeed, you need a new release

JeroenDeDauw commented 9 months ago

Here is what to do: https://github.com/SemanticMediaWiki/SemanticCite/issues/118