SemanticMediaWiki / SemanticCite

Allows to manage citation resources using semantic annotations
https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Cite
Other
24 stars 13 forks source link

Problem with Find citable metadata #42

Closed andbue closed 7 years ago

andbue commented 7 years ago

Setup and configuration

Issue

Using the "Find citable metadata"-Page works for me only in "Raw" mode. Searching for any DOI or other identifier results in a blank page. The PHP error I get is "Fatal error: Call to a member function getValueFormatter() on null in /var/www/mediawiki/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_String.php on line 111".

Any idea what could be the problem?

Thanks!

mwjames commented 7 years ago

Hi,

Searching for any DOI or other identifier results in a blank page. The PHP error I get is "Fatal error: Call to a member function getValueFormatter() on null in

This has been fixed back in November on the master branch but as of now we haven't released any new version.

PS: @kghbln in case we want to do a release then composer.json needs to be adjusted with:

Remove |~3.0 for the release

and re-add it after the release to ensure ~3.0 isn't part of the boundary yet.

Cheers

On 4/25/17, andbue notifications@github.com wrote:

Setup and configuration

  • SMW version: 2.5.1
  • SCI version: 1.2.0
  • MW version: 1.28.1
  • DB (MySQL etc.): SQLite

Issue

Using the "Find citable metadata"-Page works for me only in "Raw" mode. Searching for any DOI or other identifier results in a blank page. The PHP error I get is "Fatal error: Call to a member function getValueFormatter() on null in /var/www/mediawiki/extensions/SemanticMediaWiki/includes/datavalues/SMW_DV_String.php on line 111".

Any idea what could be the problem?

Thanks!

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticCite/issues/42

kghbln commented 7 years ago

This should be a SCI 1.3.0 due to https://github.com/SemanticMediaWiki/SemanticCite/pull/38 which breaks with SMW 2.3.x. New minimum requirement is SMW 2.5.x if I am not mistaken?!

kghbln commented 7 years ago

It will be SCI 1.3.0 anyways since https://github.com/SemanticMediaWiki/SemanticCite/commit/2c5a153cfb84d57d972eaeae5e8ffdbb05b84cb6 requires PHP 5.5+. To avoid breakage with SMW 2.3 I could however tag this version alternatively.

@mwjames A short hint which way you prefer will be cool

mwjames commented 7 years ago

A short hint which way you prefer will be cool

If you want to make a quick 1.3 without the 5.5 requirement then this is fine. The related fixes are done before the cut and include fd76a08 and 008097d.

Again, I have no strong preference.

kghbln commented 7 years ago

Again, I have no strong preference.

Ok, will do a 1.2.1 with the tag at https://github.com/SemanticMediaWiki/SemanticCite/commit/008097d0eb8e928481c6e453295dba3aa64833de

Compat breaking 1.3.0 can be done next week or so.

kghbln commented 7 years ago

Ah this is getting to complicated. 1.3.0 for master and if somebody complains he or she could get an unofficial 1.2.1 tag. ;)

kghbln commented 7 years ago

This was not a good week for me, however finally SCI 1.3.0 is out. Thanks for sitting tight!