Input field label on "Special:FindCitableMetadata" should be localizable

[kghbln]

Setup and configuration

• SCI version: master

Issue

The input field label on special page "FindCitableMetadata" should be localizable and probably be called "Source" instead of "Type"

Steps to reproduce the observation (recommendation is to use the sandbox):

See here.

[mwjames]

The input field label on special page "FindCitableMetadata" should be localizable and probably be called "Source" instead of "Type"

Well, currently this is hard-coded https://github.com/SemanticMediaWiki/SemanticCite/blob/master/src/Specials/CitableMetadata/PageBuilder.php#L139.

[kghbln]

Well, currently this is hard-coded https://github.com/SemanticMediaWiki/SemanticCite/blob/master/src/Specials/CitableMetadata/PageBuilder.php#L139.

Probably addOptionSelectList()just needs to be an array together with replacing "Type:" by $messageBuilder->getMessage( 'sci-metadata-search-type-label' )->text()?

[mwjames]

Probably addOptionSelectList()just needs to be an array together with replacing "Type:" by

Only Type: needs to replaced by something like $messageBuilder->getMessage( 'sci-metadata-search-type-label' )->text().

[kghbln]

Only Type: needs to replaced by something like $messageBuilder->getMessage( 'sci-metadata-search-type-label' )->text()

Ah ok, since the whole content is already treated as an array.