SemanticMediaWiki / SemanticCite

Allows to manage citation resources using semantic annotations
https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Cite
Other
24 stars 13 forks source link

tooltip does not show up #86

Closed bescheid closed 4 years ago

bescheid commented 4 years ago

Setup and configuration

Issue

Hovering over cite-numbers only produces a loading symbol.

The browser console produces a stack trace and outputs:

VM3336:230 Uncaught TypeError: api.parse is not a function

The error seems to have been discussed at #70, but no solution has been presented.

Steps to reproduce the observation (recommendation is to use the sandbox):

https://www.univie.ac.at/rel_jap/an/Sandkiste2/SCI_example

kghbln commented 4 years ago

The error seems to have been discussed at #70, but no solution has been presented.

I believe @JeroenDeDauw suggested to downgrade SCI. Change the line in your "composer.local.json" file to "mediawiki/semantic-cite": "~2.0.0" and see what happens.

kghbln commented 4 years ago

@mwjames I just looked at the commits and saw the unreleased pull which slipped my attention: https://github.com/SemanticMediaWiki/SemanticCite/pull/71 Actually doing a SCI 2.1.1 release will be another way to resolve this?!

bescheid commented 4 years ago

I believe @JeroenDeDauw suggested to downgrade SCI. Change the line in your "composer.local.json" file to "mediawiki/semantic-cite": "~2.0.0" and see what happens.

Thank you for clarifying Jeroen's cryptic suggestion, I will try...

bescheid commented 4 years ago

Change the line in your "composer.local.json" file to "mediawiki/semantic-cite": "~2.0.0" and see what happens.

This crushed my system. Had to re-upgrade SCI to 2.1 to keep the site running...

kghbln commented 4 years ago

This crushed my system. Had to re-upgrade SCI to 2.1 to keep the site running...

I am a bit surprised but yeah, perhaps a new release is the best way.

bescheid commented 4 years ago

This seems to pass the task over to roadmap #82. Many thanks in advance for your efforts. For the time being, I will stay with extension:cite and/or disable SCI tooltips by CSS. I leave this issue open, however...

mwjames commented 4 years ago

This seems to pass the task over to @mwjames. Many thanks in advance for your efforts. For the time being, I will stay with extension:cite and/or disable SCI tooltips by CSS. I leave this issue open, however...

I don't know what and why you have an issue here but #71 is in place to account for the cluster.... produced by the WMF. Anyway as far as I remember [0] uses MW 1.31 and SCI 2.1 and it works.

[0] https://www.semantic-mediawiki.org/wiki/Help:Import_vocabulary

On 5/14/20, bescheid notifications@github.com wrote:

This seems to pass the task over to @mwjames. Many thanks in advance for your efforts. For the time being, I will stay with extension:cite and/or disable SCI tooltips by CSS. I leave this issue open, however...

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticCite/issues/86#issuecomment-628534975

mwjames commented 4 years ago

I don't know what and why you have an issue here but #71 is in place

See also [0].

[0] https://github.com/SemanticMediaWiki/SemanticCite/commit/186e1698dea4bf8a531e50aaf4214f241126b9f5

On 5/15/20, James HK jamesin.hongkong.1@gmail.com wrote:

This seems to pass the task over to @mwjames. Many thanks in advance for your efforts. For the time being, I will stay with extension:cite and/or disable SCI tooltips by CSS. I leave this issue open, however...

I don't know what and why you have an issue here but #71 is in place to account for the cluster.... produced by the WMF. Anyway as far as I remember [0] uses MW 1.31 and SCI 2.1 and it works.

[0] https://www.semantic-mediawiki.org/wiki/Help:Import_vocabulary

On 5/14/20, bescheid notifications@github.com wrote:

This seems to pass the task over to @mwjames. Many thanks in advance for your efforts. For the time being, I will stay with extension:cite and/or disable SCI tooltips by CSS. I leave this issue open, however...

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticCite/issues/86#issuecomment-628534975

kghbln commented 4 years ago

@mwjames So doing a release as suggested in https://github.com/SemanticMediaWiki/SemanticCite/issues/86#issuecomment-628106831 will help regain paradise?

mwjames commented 4 years ago

@mwjames So doing a release as suggested in https://github.com/SemanticMediaWiki/SemanticCite/issues/86#issuecomment-628106831 will help regain paradise?

Honestly I don't know because the current SCI 2.1.0 and MW 1.31 does work as outlined above.

On 5/16/20, Karsten Hoffmeyer notifications@github.com wrote:

@mwjames So doing a release as suggested in https://github.com/SemanticMediaWiki/SemanticCite/issues/86#issuecomment-628106831 will help regain paradise?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticCite/issues/86#issuecomment-629293273

bescheid commented 4 years ago

https://github.com/SemanticMediaWiki/SemanticCite/commit/186e1698dea4bf8a531e50aaf4214f241126b9f5 solved my problems (sorry for not finding it earlier). I added the lines suggested by @mwjames to semanticCite.php. Thk you for your efforts!

kghbln commented 4 years ago

Honestly I don't know because the current SCI 2.1.0 and MW 1.31 does work as outlined above.

It may be that I manually modified the code for it to work. I faintly remember. I will uninstall and install to get the canonical code..

mwjames commented 4 years ago

186e169 solved my problems (sorry for not finding it earlier).

But those lines should be part of a release???

On 5/16/20, bescheid notifications@github.com wrote:

Closed #86.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticCite/issues/86#event-3341420877

bescheid commented 4 years ago

Not my release (2.1.0), that's for sure.

kghbln commented 4 years ago

Not my release (2.1.0), that's for sure.

That's not was meant by the question. Anyhow this issue is a dupe in the end.

@mwjames I indeed manually changed the code since this is what composer gives me:

Loading composer repositories with package information
Updating dependencies
Package operations: 0 installs, 0 updates, 2 removals
  - Removing onoi/remi (0.4.0)
  - Removing mediawiki/semantic-cite (2.1.0)
    The package has modified files:
    M SemanticCite.php
    Discard changes [y,n,v,d,?]? 

I verified that the issue in present for MW 1.31 and SCI 2.1.0 on a totally different wiki and only after updating SCI to master the issue is gone, i.e. I will do a SCI 2.1.1 release tomorrow.

mwjames commented 4 years ago

@mwjames I indeed manually changed the code since this is what composer gives me:

Which explains the false assumption.

I will do a SCI 2.1.1 release tomorrow.

Whenever it fits your calendar.

On 5/16/20, Karsten Hoffmeyer notifications@github.com wrote:

Not my release (2.1.0), that's for sure.

That's not was meant by the question. Anyhow this issue is a dupe in the end.

@mwjames I indeed manually changed the code since this is what composer gives me:

Loading composer repositories with package information
Updating dependencies
Package operations: 0 installs, 0 updates, 2 removals
  - Removing onoi/remi (0.4.0)
  - Removing mediawiki/semantic-cite (2.1.0)
    The package has modified files:
    M SemanticCite.php
    Discard changes [y,n,v,d,?]?

I verified that the issue in present for MW 1.31 and SCI 2.1.0 on a totally different wiki and only after updating SCI to master the issue is gone, i.e. I will do a SCI 2.1.1 release tomorrow.

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticCite/issues/86#issuecomment-629336592