Open thomas-topway-it opened 8 months ago
Attention: Patch coverage is 0%
with 42 lines
in your changes are missing coverage. Please review.
Project coverage is 79.20%. Comparing base (
4f1cce3
) to head (2946b91
).
Files | Patch % | Lines |
---|---|---|
src/JsonLDSerializer.php | 0.00% | 39 Missing :warning: |
src/HookRegistry.php | 0.00% | 3 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@kghbln @JeroenDeDauw @gesinn-it-gea can we merge this?
There is no automated test. Did someone manually test this?
Some docs on expected behavior could also help. In the release notes or other documentation pages
ok, I will add a test, it won't take long
I am using it on some wikis.
I see two deprecation notices in MW 1.39:
Deprecated
: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in
/vendor/easyrdf/easyrdf/lib/Http/Response.php
on line
170
Deprecated
: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in
/vendor/easyrdf/easyrdf/lib/Http/Response.php
on line
174
@thomas-topway-it can you have a look, please?
adds json-ld serialization using https://github.com/easyrdf/easyrdf from SMW's standard RDF serialization
for testing purpose run
composer install
in the extension folder after merging the pull request https://github.com/SemanticMediaWiki/SemanticMetaTags/pull/79