Graph format: $node variable is not initialized in the else block

[jewloszewicz]

Setup

• MW version: 1.31.5
• SMW version: 3.1.0
• SRF version: 3.2.0-alpha

Issue

Error from line 186 of /var/www/smw/extensions/SemanticResultFormats/src/Graph/GraphPrinter.php: Call to a member function addParentNode() on null

[JeroenDeDauw]

Thanks for reporting this issue!

Ping @SbstnS

[SbstnS]

@jewloszewicz can you please post your inline query which causes this error so i can reproduce it.

[SbstnS]

@jewloszewicz I'm working with the same setup as you've described above but I never run into this error.

You may have made some mistakes during installing the extension. Please check the installation guide.

https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Result_Formats/Installation

[jewloszewicz]

@SbstnS Unfortunately, I don't have access to that instance anymore.

There is a mistake in the code. $node in the else statement is not initialized.

https://github.com/SemanticMediaWiki/SemanticResultFormats/blob/1b983766322732e50fa6f613e006c223f7bd9533/src/Graph/GraphPrinter.php#L168-L187

[SbstnS]

@jewloszewicz I'm not sure how then you can run into this error that you've described above....

Error from line 186 of /var/www/smw/extensions/SemanticResultFormats/src/Graph/GraphPrinter.php: Call to a member function addParentNode() on null

To me everything works as expected! If i had your inline query than i could cover the hole test scenario...

Here is the one that I used for testing.

{{#ask:[[Category:Team]]
  |?Part Of Team
  |format=graph
  |graphcolor=yes
  |graphlink=yes
  |graphname=PeopleKnows
  |graphlegend=yes
  |graphlabel=yes
  |graphsize=10,100
  |nodelabel=displaytitle
}}

[SbstnS]

@JeroenDeDauw But I noticed a few parts while testing the code that could be improved. I'll do this in a new PullRequest.

[alex-mashin]

I think, this bug has been fixed by #749.