SemanticMediaWiki / SemanticResultFormats

Provides additional visualizations (result formats) for Semantic MediaWiki
https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Result_Formats
Other
45 stars 75 forks source link

Cannot merge a pull request #674

Closed alex-mashin closed 2 years ago

alex-mashin commented 2 years ago

Cannot merge pull request #675.

Scrutinizer test does not run.

Waiting for External Code Coverage    61:50
Waits for external service to send code coverage to Scrutinizer.
The code coverage data was not received within the specified time. Please make sure your third-party service is configured to send code coverage data.

Code coverage data is not yet available.
Code Coverage was not sent to Scrutinizer.
Make sure that you have set-up your external service correctly.
You can find more information on this in the documentation:

    https://scrutinizer-ci.com/docs/tools/external-code-coverage/

If you need help you can also email support@scrutinizer-ci.com.

https://scrutinizer-ci.com/g/SemanticMediaWiki/SemanticResultFormats/inspections/5296be6c-b321-40fb-b5c1-f1274e4f0a1b

JeroenDeDauw commented 2 years ago

Just ignore scrutinizer, it is not even running the tests anyway. Coverage removed with https://github.com/SemanticMediaWiki/SemanticResultFormats/commit/a5bc6df206c46b6d00bd819da10d9c44f014ceff

Maybe should fully remove Scrutinizer and add a proper modern CI setup

alex-mashin commented 2 years ago

And now checks of #676 are still pending.

alex-mashin commented 2 years ago

Another hanging pull request: https://github.com/SemanticMediaWiki/SemanticExtraSpecialProperties/pull/170.

gesinn-it-gea commented 2 years ago

Thanks @alex-mashin for your contributions! I'd like to get CI and coverage working again. This makes it easier to accept PRs.

alex-mashin commented 2 years ago

Thanks @alex-mashin for your contributions! I'd like to get CI and coverage working again. This makes it easier to accept PRs.

I have corrected the unit test for this format.

alex-mashin commented 2 years ago

The PR in question have been merged.