[timeline] Error in SRF 4.x Call to a member function getFullUrl() on null

[krabina]

Setup

• MW version: 1.35.5
• DB (MySQL etc.): 10.3.34-MariaDB
• PHP version: 7.4.28
• SMW version: 4.0.1 (fd1b241)
• SRF version: 4.0.1 (44c0bd8)
• Browsers and versions (if applicable):

Issue

Timeline format throws an error in latest version of SRF. Personally, I don't have a problem, since timeline/eventline formats are very outdated, and we have ModernTimeline now. However, this should either be fixes or the result format should be removed/deprecated and documented.

The bigger problem: ModernTimeline breaks as well

`[YlQgoquVnfKNc5I5jjCYiwABTw8] /OGD-Cockpit Error from line 343 of /extensions/SemanticResultFormats/formats/timeline/SRF_Timeline.php: Call to a member function getFullUrl() on null

Backtrace:

#0 /extensions/SemanticResultFormats/formats/timeline/SRF_Timeline.php(157): SRFTimeline->handlePropertyValue(SMWWikiPageValue, integer, SMW\Query\PrintRequest, boolean, boolean, boolean, boolean, boolean, string, string, NULL, boolean, array)
#1 /extensions/SemanticResultFormats/formats/timeline/SRF_Timeline.php(92): SRFTimeline->getEventsHTML(SMW\Query\QueryResult, integer, boolean)
#2 /extensions/SemanticMediaWiki/src/Query/ResultPrinters/ResultPrinter.php(339): SRFTimeline->getResultText(SMW\Query\QueryResult, integer)
#3 /extensions/SemanticMediaWiki/src/Query/ResultPrinters/ResultPrinter.php(304): SMW\Query\ResultPrinters\ResultPrinter->buildResult(SMW\Query\QueryResult)
#4 /extensions/SemanticMediaWiki/includes/query/SMW_QueryProcessor.php(348): SMW\Query\ResultPrinters\ResultPrinter->getResult(SMW\Query\QueryResult, array, integer)
#5 /extensions/SemanticMediaWiki/src/ParserFunctions/AskParserFunction.php(364): SMWQueryProcessor::getResultFromQuery(SMWQuery, array, integer, integer)
#6 /extensions/SemanticMediaWiki/src/ParserFunctions/AskParserFunction.php(196): SMW\ParserFunctions\AskParserFunction->doFetchResultsFromFunctionParameters(array, array)
#7 /extensions/SemanticMediaWiki/src/ParserFunctionFactory.php(402): SMW\ParserFunctions\AskParserFunction->parse(array)
#8 /includes/parser/Parser.php(3340): SMW\ParserFunctionFactory->SMW\{closure}(Parser, string, string, string, string, string, string, string, string, string, string, string)
#9 /includes/parser/Parser.php(3047): Parser->callParserFunction(PPFrame_Hash, string, array)
#10 /includes/parser/PPFrame_Hash.php(263): Parser->braceSubstitution(array, PPFrame_Hash)
#11 /includes/parser/Parser.php(2887): PPFrame_Hash->expand(PPNode_Hash_Tree, integer)
#12 /includes/parser/Parser.php(1556): Parser->replaceVariables(string)
#13 /includes/parser/Parser.php(651): Parser->internalParse(string)
#14 /includes/content/WikitextContent.php(374): Parser->parse(string, Title, ParserOptions, boolean, boolean, integer)
#15 /includes/content/AbstractContent.php(590): WikitextContent->fillParserOutput(Title, integer, ParserOptions, boolean, ParserOutput)
#16 /includes/Revision/RenderedRevision.php(263): AbstractContent->getParserOutput(Title, integer, ParserOptions, boolean)
#17 /includes/Revision/RenderedRevision.php(235): MediaWiki\Revision\RenderedRevision->getSlotParserOutputUncached(WikitextContent, boolean)
#18 /includes/Revision/RevisionRenderer.php(215): MediaWiki\Revision\RenderedRevision->getSlotParserOutput(string)
#19 /includes/Revision/RevisionRenderer.php(152): MediaWiki\Revision\RevisionRenderer->combineSlotOutput(MediaWiki\Revision\RenderedRevision, array)
#20 [internal function]: MediaWiki\Revision\RevisionRenderer->MediaWiki\Revision\{closure}(MediaWiki\Revision\RenderedRevision, array)
#21 /includes/Revision/RenderedRevision.php(197): call_user_func(Closure, MediaWiki\Revision\RenderedRevision, array)
#22 /includes/poolcounter/PoolWorkArticleView.php(216): MediaWiki\Revision\RenderedRevision->getRevisionParserOutput()
#23 /includes/poolcounter/PoolCounterWork.php(162): PoolWorkArticleView->doWork()
#24 /includes/page/Article.php(810): PoolCounterWork->execute()
#25 /includes/actions/ViewAction.php(80): Article->view()
#26 /includes/MediaWiki.php(532): ViewAction->show()
#27 /includes/MediaWiki.php(313): MediaWiki->performAction(Article, Title)
#28 /includes/MediaWiki.php(945): MediaWiki->performRequest()
#29 /includes/MediaWiki.php(548): MediaWiki->main()
#30 /index.php(53): MediaWiki->run()
#31 /index.php(46): wfIndexMain()
#32 {main}
`