Closed thomas-topway-it closed 1 year ago
the test fails because this file tests/phpunit/Integration/JSONScript/datatables-01.json checks for the wrong theme (default theme is now "basic")
Merging #730 (46b432b) into master (35163c5) will increase coverage by
1.28%
. The diff coverage is91.93%
.
@@ Coverage Diff @@
## master #730 +/- ##
============================================
+ Coverage 40.35% 41.64% +1.28%
- Complexity 2061 2116 +55
============================================
Files 75 76 +1
Lines 7268 7449 +181
============================================
+ Hits 2933 3102 +169
- Misses 4335 4347 +12
Impacted Files | Coverage Δ | |
---|---|---|
formats/slideshow/SRF_SlideShow.php | 0.00% <ø> (ø) |
|
formats/carousel/Carousel.php | 91.27% <91.27%> (ø) |
|
formats/datatables/DataTables.php | 94.73% <100.00%> (+1.87%) |
:arrow_up: |
formats/filtered/src/Filtered.php | 93.90% <100.00%> (+0.07%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
For documentation. The datatables PR includes a workaround to work with the current version of SMW. A future version without the workaround in SRF needs to be implemented here SemanticMediaWiki/res/smw/data/ext.smw.dataItem.uri.js But this might affect other result formats as well, so we did not want to go there yet. This is probably also related to https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/3545
This PR is still work in progress. Will let you know when we are finished.
We believe or PR is ready now for integration. We improved the datatables format, fixed serveral bugs, added a new carousel format and provide php unit tests, json integration tests, and js QUnit tests. We have tested on several production wikis on 1.35. @JeroenDeDauw @gesinn-it-gea are we ready to merge?
This PR is made in reference to: KM-A Knowledge Management Associates upgrade of SemanticResultFormats Datatables This PR addresses or contains: