SemanticMediaWiki / SemanticResultFormats

Provides additional visualizations (result formats) for Semantic MediaWiki
https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Result_Formats
Other
45 stars 75 forks source link

Replacing unmaintained extension GraphViz with Diagrams #745

Closed YOUR1 closed 1 year ago

YOUR1 commented 1 year ago

The GraphViz extension is unmaintained and not working with MW versions newer then 1.32. Diagrams seems to do the same, and is working properly. We've tested it and came to the conclusion that Diagrams is a good replacement.

codecov-commenter commented 1 year ago

Codecov Report

Merging #745 (4166b60) into master (993be16) will decrease coverage by 0.02%. The diff coverage is 20.68%.

@@             Coverage Diff              @@
##             master     #745      +/-   ##
============================================
- Coverage     39.61%   39.59%   -0.03%     
- Complexity     2046     2054       +8     
============================================
  Files            75       75              
  Lines          7234     7251      +17     
============================================
+ Hits           2866     2871       +5     
- Misses         4368     4380      +12     
Impacted Files Coverage Δ
formats/graphviz/SRF_Process.php 0.00% <0.00%> (ø)
src/Graph/GraphPrinter.php 0.00% <0.00%> (ø)
src/Graph/GraphFormatter.php 78.07% <42.85%> (-4.29%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

JeroenDeDauw commented 1 year ago

This is a breaking change and thus requires bumping the SRF version to 5.x. This could be avoided by supporting both extensions. Not sure if that is feasible.

YOUR1 commented 1 year ago

This is a breaking change and thus requires bumping the SRF version to 5.x. This could be avoided by supporting both extensions. Not sure if that is feasible.

I’ll see if I can come up with something 👌

YOUR1 commented 1 year ago

Don't know why the tests are failing; whenever I run the test locally, it succeeds. I'll see what's up tomorrow.

gesinn-it-gea commented 1 year ago

To my opinion, it would be okay to release SRF 5.x and end the tradition, that SRF always has the same major verison as SMW.

JeroenDeDauw commented 1 year ago

Totally agree, we have stopped following that tradition a while ago and are only coincidentally on the same major version now.