Closed YOUR1 closed 1 year ago
Merging #745 (4166b60) into master (993be16) will decrease coverage by
0.02%
. The diff coverage is20.68%
.
@@ Coverage Diff @@
## master #745 +/- ##
============================================
- Coverage 39.61% 39.59% -0.03%
- Complexity 2046 2054 +8
============================================
Files 75 75
Lines 7234 7251 +17
============================================
+ Hits 2866 2871 +5
- Misses 4368 4380 +12
Impacted Files | Coverage Δ | |
---|---|---|
formats/graphviz/SRF_Process.php | 0.00% <0.00%> (ø) |
|
src/Graph/GraphPrinter.php | 0.00% <0.00%> (ø) |
|
src/Graph/GraphFormatter.php | 78.07% <42.85%> (-4.29%) |
:arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
This is a breaking change and thus requires bumping the SRF version to 5.x. This could be avoided by supporting both extensions. Not sure if that is feasible.
This is a breaking change and thus requires bumping the SRF version to 5.x. This could be avoided by supporting both extensions. Not sure if that is feasible.
I’ll see if I can come up with something 👌
Don't know why the tests are failing; whenever I run the test locally, it succeeds. I'll see what's up tomorrow.
To my opinion, it would be okay to release SRF 5.x and end the tradition, that SRF always has the same major verison as SMW.
Totally agree, we have stopped following that tradition a while ago and are only coincidentally on the same major version now.
The GraphViz extension is unmaintained and not working with MW versions newer then 1.32. Diagrams seems to do the same, and is working properly. We've tested it and came to the conclusion that Diagrams is a good replacement.