search

SemanticMediaWiki / SemanticResultFormats

Provides additional visualizations (result formats) for Semantic MediaWiki
https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Result_Formats
Other
45 stars 75 forks source link

Fix issue 784 slidesToShow #793

Closed thomas-topway-it closed 6 months ago

thomas-topway-it commented 8 months ago

the issue was caused by 2 concurrent problems, the parameter slick-responsive with wrong default value prevented all subsequent parameters to work, including slick-slidesToShow, now all the parameters listed here https://www.semantic-mediawiki.org/wiki/Help:Carousel_format should work correctly. It has also been implemented the suggestion of @michaelfreiberg mentioned in the same issue

codecov-commenter commented 8 months ago

Codecov Report

Merging #793 (6bca9ca) into master (c43dc15) will increase coverage by 0.04%. Report is 1 commits behind head on master. The diff coverage is 93.10%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff              @@
##             master     #793      +/-   ##
============================================
+ Coverage     40.04%   40.09%   +0.04%     
- Complexity     2324     2331       +7     
============================================
  Files            78       78              
  Lines          8236     8246      +10     
============================================
+ Hits           3298     3306       +8     
- Misses         4938     4940       +2
Files Coverage Δ
formats/carousel/Carousel.php 90.65% <93.10%> (-0.62%) :arrow_down:

:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

krabina commented 8 months ago

@gesinn-it-gea is this ready to merge?