SemanticMediaWiki / SemanticResultFormats

Provides additional visualizations (result formats) for Semantic MediaWiki
https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Result_Formats
Other
45 stars 75 forks source link

Update ci.yml #798

Closed kizule closed 10 months ago

kizule commented 10 months ago

Removed MediaWiki 1.40 because of:

  1. I don't remember that something related to Semantic MediaWiki has ever officially supported a non-LTS version of MediaWiki
  2. Tests are failing for MediaWiki 1.40, it's not worth fixing it as MediaWiki 1.40 is non-LTS, because of previous reasons.
codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (80b0924) 40.04% compared to head (499158a) 40.04%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #798 +/- ## ========================================= Coverage 40.04% 40.04% Complexity 2324 2324 ========================================= Files 78 78 Lines 8236 8236 ========================================= Hits 3298 3298 Misses 4938 4938 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gesinn-it-gea commented 10 months ago

The question is: should we include the latest non-LTS version to indicate that there may be some open issues with a particular version? In my opinion, testing should reveal potential problems before the next LTS version is released. Unfortunately, the official MediaWiki Docker images only appear with the release, so CI could only be adapted to them very late.

What exactly bothers you about the failing CI for 1.40. The red cross?

grafik

JeroenDeDauw commented 10 months ago

Having the failing build does make it more difficult to see if something is wrong with the PR, especially if you don't already know that MW 40 is expected to fail.

gesinn-it-gea commented 10 months ago

I have removed 1.40 now

gesinn-it-gea commented 10 months ago

done