search

SemanticMediaWiki / SemanticResultFormats

Provides additional visualizations (result formats) for Semantic MediaWiki
https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Result_Formats
Other
45 stars 75 forks source link

Refactor word wrapping and on-node properties #817

Closed alex-mashin closed 2 months ago

alex-mashin commented 4 months ago

Refactor word wrapping and on-node properties, to facilitate further changes.

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 39.68%. Comparing base (6509f4a) to head (0808f8f).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #817 +/- ## ============================================ - Coverage 40.12% 39.68% -0.44% + Complexity 2332 2329 -3 ============================================ Files 78 78 Lines 8247 8322 +75 ============================================ - Hits 3309 3303 -6 - Misses 4938 5019 +81 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alex-mashin commented 4 months ago

@YOUR1, please take part in the review.

krabina commented 2 months ago

Can we merge this, @YOUR1 ?

alex-mashin commented 2 months ago

Can we merge this, @YOUR1 ?

No, we shouldn't. I am abandoning this request. I have fully rewritten the whole format, only unit tests are remaining.

alex-mashin commented 2 months ago

Abandoning in favour of a more significant change.