search

SemanticMediaWiki / SemanticResultFormats

Provides additional visualizations (result formats) for Semantic MediaWiki
https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Result_Formats
Other
45 stars 75 forks source link

Restore datatable filter responsive handling #824

Closed alistair3149 closed 2 months ago

alistair3149 commented 3 months ago

The styles added by SRF was overriding the responsive media query rules set by datatables. This should restore the behavior.

gesinn-it-gea commented 3 months ago

@krabina can you have a look at this PR

krabina commented 3 months ago

@thomas-topway-it can you check this, please?

thomas-topway-it commented 3 months ago

I have tested it here https://fina.knowledge.wiki/Copies_or_Translations_of_Printed_Books

with the latest SemanticResultFormats and it looks fine. The style restores the original datatables styling.

Also (this is unrelated to this issue) is there a specific reason for the existence of this repository https://github.com/semanticMediaWiki/SemanticresultFormats

"result" lowercase ?

thomas-topway-it commented 3 months ago

however, I've tested again with this version https://github.com/Knowledge-Wiki/SemanticResultFormats/tree/datatables-v2-improvements (rebased from SemanticResultFormats master) and the styling issue does not show also without the patch

krabina commented 2 months ago

@alistair3149 can you confirm that the desired behavior is there in current master and we can ignore this?

alistair3149 commented 2 months ago

Yes it is fixed now, closing the PR.