search

SemanticMediaWiki / SemanticResultFormats

Provides additional visualizations (result formats) for Semantic MediaWiki
https://www.semantic-mediawiki.org/wiki/Extension:Semantic_Result_Formats
Other
45 stars 75 forks source link

Updates to wfFindFile again #838

Closed D-Groenewegen closed 3 months ago

D-Groenewegen commented 3 months ago

No need to support the older method wfFindFile (pre-MW 1.34). Since SRF 4.0.x, the minimum version is MW 1.35. Also corrected an earlier oversight.

778

codecov-commenter commented 3 months ago

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 40.79%. Comparing base (c0dd4bb) to head (394f5f6). Report is 25 commits behind head on master.

Files Patch % Lines
formats/dygraphs/SRF_Dygraphs.php 0.00% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #838 +/- ## ============================================ + Coverage 40.12% 40.79% +0.66% - Complexity 2332 2404 +72 ============================================ Files 78 81 +3 Lines 8247 7852 -395 ============================================ - Hits 3309 3203 -106 + Misses 4938 4649 -289 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

alexander-gesinn commented 3 months ago

Thanks for your PR! We need to explain the CI and testing a little bit better :-) We now have Docker Compose based CI that can be used for testing locally by simply running "make ci". See https://github.com/gesinn-it-pub/docker-compose-ci