SemanticMediaWiki / SemanticScribunto

Provides service functions to support the Scribunto extension
Other
24 stars 14 forks source link

Adding mw.smw.set to available smw functions #18

Closed oetterer closed 7 years ago

oetterer commented 7 years ago

I added the smw parser function "set" to the available lua functions.

The implementation re-uses as much code as possible from the smw parser function call. It utilizes class ParserFunctionFactory to get the same kind of object, the normal parser function call would use. It then defers parameter processing and the semantic storage process to this object the same way a normal parser function call would use.

Difference to the parser function call is:

oetterer commented 7 years ago

btw: I'm going to write documentation for all new functions in https://github.com/SemanticMediaWiki/SemanticScribunto/blob/master/docs/functions.md once the code is integrated. promise!

mwjames commented 7 years ago

... now on my weekly support slot ...

btw: I'm going to write documentation for all new functions in https://github.com/SemanticMediaWiki/SemanticScribunto/blob/master/docs/functions.md once the code is integrated. promise!

You don't have to promise, it would be a shame if people cannot make use of your effort just because of some missing guidelines.

PS: After all the PR's have been merged, don't forget to put yourself as author to this extension given the expected amount of contribution.

mwjames commented 7 years ago

There are some design issues but some have already being addressed in #20 therefore merging this so we can move forward.

JeroenDeDauw commented 7 years ago

Now the one with the improved code has a merge conflict with master...