SemanticMediaWiki / SemanticScribunto

Provides service functions to support the Scribunto extension
Other
24 stars 14 forks source link

Adding mw.smw.subobject to available smw functions #19

Closed oetterer closed 7 years ago

oetterer commented 7 years ago

Here comes the smw parser function "subobject" to the available lua functions.

I'm not sure, if I should have branched before my previous PR, since this now includes both. Sry for the mess...

Nevertheless. Againg, the implementation re-uses as much code as possible from the smw parser function call. It utilizes class ParserFunctionFactory to get the same kind of object, the normal parser function call to #subobject would use. It then defers parameter processing and the semantic storage process to this object the same way a normal parser function call would use.

Difference to the parser function call is:

oetterer commented 7 years ago

there is a copy/paste error in 1432e51. Shoud read Adding mw.smw.subobject to available smw functions

oetterer commented 7 years ago

I recommend closing this. after the two other PRs are in a satisfiable state and integrated in master, I re-add this. multiple PRs better not be done in parallel branches me thinks... :(

mwjames commented 7 years ago

Do you want to close this one?