fix #48 (mw.set drops property names with numbers in key-value mode)

[oetterer]

adds:

• a test, including fixture, to reproduce the problem
• a fix for the problem (regular expressions and I are still at odds, it seems)

closes #48

[oetterer]

hm. Can I be so bold and assume, that the failing master test is not caused by my fix...

[mwjames]

hm. Can I be so bold and assume, that the failing master test is not caused by my fix..

Yes, and most likely caused by [0].

PS: [1] shows how to deal with different MW releases where the output changed.

[0] https://github.com/wikimedia/mediawiki/commit/3bae295aef6f6495dc37802f1f4f6956c9a5648c [1] https://github.com/SemanticMediaWiki/SemanticMediaWiki/blob/24ef304aa31a2cd20123bf5e40b1a178dd7d5f31/tests/phpunit/Integration/JSONScript/TestCases/s-0014.json#L70-L112

Cheers

On 3/22/18, Tobias Oetterer notifications@github.com wrote:

hm. Can I be so bold and assume, that the failing master test is not caused by my fix...

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticScribunto/pull/49#issuecomment-375333692

[oetterer]

thank you @mwjames, that helps. Will fix the tests tomorrow!

[oetterer]

@mwjames you could have mentioned, that I had to patch \SMW\Scribunto\Integration\JSONScript\SemanticScribuntoJsonTestCaseScriptRunnerTest first to use this feature! ;) All ready now. I took the liberty to merge the test patches, but normally I would let you (or @kghbln) do the honors.

[mwjames]

@mwjames you could have mentioned, that I had to patch

Sorry this slipped my mind.

I thought I'd give you an early feedback so that you can work your way through without me having to intervene during the weekend.

[kghbln]

@mwjames Should I do a 1.1.1 next week?

[mwjames]

Should I do a 1.1.1 next week?

If you have time then that would be splendid.