search

SemanticMediaWiki / SemanticScribunto

Provides service functions to support the Scribunto extension
Other
24 stars 14 forks source link

Start 1.2.0 #53

Closed kghbln closed 6 years ago

kghbln commented 6 years ago

@mwjames I have no idea what is going on. The errors should not appear I believe. :|

oetterer commented 6 years ago

@kghbln looks like travis installs the wrong smw version:

 731 - Installing mediawiki/semantic-media-wiki (2.5.x-dev e0c6791): Cloning e0c679168a from cache

should be 3.0-dev somthing

If I had to venture a guess this entry in composer.json's require-dev:

"mediawiki/semantic-media-wiki": "@dev"

picks the latest dev commit? maybe try and change to "~3.0@dev"?

kghbln commented 6 years ago

This commit is restoring the status ante so it should install 3.0. Probably just a matter of merging to make the issue go away. This is a bit exhausting but probably the way it is.

oetterer commented 6 years ago

nope. I'll leave you to it. Sorry, that I couldn't be of any help. :(

mwjames commented 6 years ago

nope. I'll leave you to it. Sorry, that I couldn't be of any help. :(

Please remember that composer requirements are registered with packagist.org which currently has only ~2.5 as constraint. This RR changes those requirements only after it has been merged therefore it is natural that test fail hat require 3.0. The tasks is as to add ~2.5|~3.0 and merge the PR.

Cheers

On 3/27/18, Tobias Oetterer notifications@github.com wrote:

nope. I'll leave you to it. Sorry, that I couldn't be of any help. :(

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticScribunto/pull/53#issuecomment-376536608

kghbln commented 6 years ago

I guess another senior moments case for me. I think to remember that I forget this all the time. :( Thanks for getting this off the ground.

kghbln commented 6 years ago

Yeah, we are in fluff again.