search

SemanticMediaWiki / SemanticScribunto

Provides service functions to support the Scribunto extension
Other
23 stars 14 forks source link

add feature #55: set and subobject can take property values from subtables #56

Closed oetterer closed 6 years ago

oetterer commented 6 years ago

Fixes #55

oetterer commented 6 years ago

Looks to me, the failing test originates in smw, not ssc. see also [0].

[0] https://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/jobs/402183163

mwjames commented 6 years ago

Looks to me, the failing test originates in smw, not ssc. see also [0].

[0] https://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/jobs/402183163

A quick look reveals that it is caused by MW and the MCR.

PS: Being absent for two month means that things are getting worse for extension developers by the month. I'll try to have look at it during my weekend sprint.

Fatal error: Uncaught exception 'MWException' with message
'RevisionStore for its_a_mw cannot be used with a DB connection for
its_a_mw-sunittest_' in
/home/travis/build/SemanticMediaWiki/mw/includes/Storage/RevisionStore.php:1983
Stack trace:
#0 /home/travis/build/SemanticMediaWiki/mw/includes/Storage/RevisionStore.php(406):
MediaWiki\Storage\RevisionStore->checkDatabaseWikiId()
#1 /home/travis/build/SemanticMediaWiki/mw/includes/Storage/PageUpdater.php(1093):
MediaWiki\Storage\RevisionStore->insertRevisionOn()
#2 /home/travis/build/SemanticMediaWiki/mw/includes/Storage/PageUpdater.php(731):
MediaWiki\Storage\PageUpdater->doCreate()
#3 /home/travis/build/SemanticMediaWiki/mw/includes/page/WikiPage.php(1855):
MediaWiki\Storage\PageUpdater->saveRevision()
#4 /home/travis/build/SemanticMediaWiki/mw/extensions/SemanticMediaWiki/tests/phpunit/Utils/PageCreator.php(93):
WikiPage->doEditContent()
#5 /home/travis/build/SemanticMediaWiki/mw/extensions/SemanticMediaWiki/tests/phpunit/Utils/PageCreator.php(71):
SMW\Tests\Utils\PageCreator->doEdit()

Cheers

On 7/12/18, Tobias Oetterer notifications@github.com wrote:

Looks to me, the failing test originates in smw, not ssc. see also [0].

[0] https://travis-ci.org/SemanticMediaWiki/SemanticMediaWiki/jobs/402183163

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticScribunto/pull/56#issuecomment-404305002

mwjames commented 6 years ago

@oetterer Thanks for the test coverage and the quick response to the request.

Tests on master were the only one that failed due to extraneous reasons and should be resolved by now. I'll leave the release to both of you @kghbln @oetterer.

s7eph4n commented 6 years ago

Thanks, @oetterer ! And welcome back, @mwjames !

oetterer commented 6 years ago

@mwjames I hope you had a relaxing vacation in the last two month! Or at least a good time! :)

about the tests: wouldn't it be better to mark the test on master as _allowfailures. Also, shouldn't we chnage the test on 1.28 to 1.31?

mwjames commented 6 years ago

about the tests: wouldn't it be better to mark the test on master as allow_failures. Also, shouldn't we chnage the test on 1.28 to 1.31?

This should be the last resort and for an hour I have tried several things with https://github.com/SemanticMediaWiki/SemanticMediaWiki/commit/73c62fc565c5bee7bd0c019741373e542d0d898f solving the issue [0].

[0] https://travis-ci.org/SemanticMediaWiki/SemanticScribunto/builds/403949826

kghbln commented 6 years ago

I will do a 1.2.0 release probably on Wednesday if there are no objections from anyone of you.