search

SemanticMediaWiki / SemanticScribunto

Provides service functions to support the Scribunto extension
Other
23 stars 14 forks source link

[CI] Switch to PHP 7+ and MW 1.31+ #66

Closed mwjames closed 5 years ago

mwjames commented 5 years ago

This PR is made in reference to: #65

This PR addresses or contains:

This PR includes:

Fixes #65

mwjames commented 5 years ago

@kghbln FYI

kghbln commented 5 years ago

@mwjames Thanks for the note!

Uses wfLoadExtension( "Scribunto" )

This was already a requirement for the last release. Thus 2.1.0 and not 3.0.0: https://github.com/SemanticMediaWiki/SemanticScribunto/issues/68

mwjames commented 5 years ago

This was already a requirement for the last release. Thus 2.1.0 and not 3.0.0: https://github.com/SemanticMediaWiki/SemanticScribunto/issues/68

Yes, but as the references issue noted this what about the CI setup which hadn't been updated in a while.

On 8/5/19, Karsten Hoffmeyer notifications@github.com wrote:

Thanks for the note!

Uses wfLoadExtension( "Scribunto" )

This was already a requirement for the last release. Thus 2.1.0 and not 3.0.0: https://github.com/SemanticMediaWiki/SemanticScribunto/issues/68

-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticScribunto/pull/66#issuecomment-518223887

JeroenDeDauw commented 5 years ago

Hi @mwjames. I suggest that when dropping support for PHP 5.x to switch straight to 7.1. 7.0 has been EoL since the beginning of the year. This is what I did with my stuff a year ago.