SemanticMediaWiki / SemanticScribunto

Provides service functions to support the Scribunto extension
Other
24 stars 14 forks source link

Make 2.1.0 release #68

Closed kghbln closed 5 years ago

kghbln commented 5 years ago
kghbln commented 5 years ago

@mwjames Any objections to making this release?

mwjames commented 5 years ago

+1

On 8/5/19, Karsten Hoffmeyer notifications@github.com wrote:

@mwjames Any objections to making this release?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticScribunto/issues/68#issuecomment-518222614

kghbln commented 5 years ago

@mwjames This drives me crazy. :| The build is now failing. Not sure if a blocker? I'd say no.

mwjames commented 5 years ago

Hi,

@mwjames This drives me crazy. :| The build is now failing. Not sure if a blocker?

I had a quick look at it and it relates to the DB version used, the CI is running MySQL (and not MariaDB) which is more strict about using temporary table reference within temporary tables [0].

The unit tests in SemanticScribunto rely on Scribunto_LuaEngineTestBase (needed because of the Lua setup etc.) which itself relies on MediaWikiTestCase and is responsible for creating table clones as TEMPORARY TABLES by default.

So, the trick is to run the test suite with option use-normal-tables to make sure that the table clones are "real" tables.

The integration tests aren't an issue because here we use SMW's infrastructure which doesn't rely on MediaWikiTestCase at all.

[0] https://dev.mysql.com/doc/refman/5.7/en/temporary-table-problems.html

Cheers

On 8/19/19, Karsten Hoffmeyer notifications@github.com wrote:

@mwjames This drives me crazy. :| The build is now failing. Not sure if a blocker?

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/SemanticMediaWiki/SemanticScribunto/issues/68#issuecomment-522337894

kghbln commented 5 years ago

Thanks for the info. I was however unable to find any "use-normal-tables" option in connection with MySQL. Not sure how I could fix this.

mwjames commented 5 years ago

I was however unable to find any "use-normal-tables" option in connection with MySQL. Not sure how I could fix this.

See #73.

kghbln commented 5 years ago

Ah ok. Couldn't have done this myself admittedly.