search

SemanticMediaWiki / SemanticScribunto

Provides service functions to support the Scribunto extension
Other
24 stars 14 forks source link

Change getQueryResult to avoid using API queries #9

Closed mint-thompson closed 8 years ago

mint-thompson commented 8 years ago

see #8

mwjames commented 8 years ago

I also suspect that tests will fail due to a change in the return structure.

mint-thompson commented 8 years ago

I've updated the meta count test to reflect the new return structure. The empty query test will currently fail, as a table is returned that still contains "results" and "printrequests" as keys. Both of these keys point to values of empty tables, so checking that ret.results and ret.printrequests are both empty tables seems like an acceptable test.

mwjames commented 8 years ago

@matthew-a-thompson Tests pass :+1: .

@cicalese Can you confirm that this works as expected (before I press the merge button).

cicalese commented 8 years ago

Thank you both! We tested the patch and it works great, so you can go ahead and merge.

mwjames commented 8 years ago

Thanks for the feedback.