search

SemanticMediaWiki / SemanticSignup

Allows adding additional fields to the user registration form, which get placed on the new users' user page, as well as stored semantically.
https://www.mediawiki.org/wiki/Extension:SemanticSignup
Other
6 stars 3 forks source link

Removed Semantic MediaWiki as a requirement #22

Open yaronkoren opened 9 years ago

yaronkoren commented 9 years ago

As noted in the comments for the README change, this file too needs to be changed; assuming that there's agreement that Semantic MediaWiki is not in fact a requirement. I also modified the extension description, and changed the URL to what I assume is the correct URL.

mwjames commented 9 years ago

I'm in the process of some additional re-factoring with changes that will most likely require SMW therefore I can't +1.

JeroenDeDauw commented 9 years ago

Change looks good, though needs verification.

@mwjames Let's please not add a dependency on SMW for the sake of it. That is not in the best interest of the users.

mwjames commented 9 years ago

Let's please not add a dependency on SMW for the sake of it. That is not in the best interest of the users.

Sorry but I'm getting quite tired of this now, the code has been dead for 1.5 years without anyone taken notice and now for some reason it becomes a battle field whether it requires SMW or not is beyond me.

JeroenDeDauw commented 9 years ago

Then why are you contesting this change? I also do not see why we'd need to create a fuzz about this.

mwjames commented 9 years ago

Then why are you contesting this change? I also do not see why we'd need to create a fuzz about this.

First of all because it breaks current tests (which of course would have been noticed by #18) ergo we don't merge with failing tests.

mwjames commented 9 years ago

The longer I look at the code the more I question whether SF is the right tool for what is being the sole purpose of this extension namely to "Allows adding additional fields to the user registration form, which get placed on the new users' user page, as well as stored semantically." but it doesn't mean I'm kicking the can by removing SF from the requirements list just because it seems to fit some agenda.

yaronkoren commented 9 years ago

I certainly don't mean to cause drama, so I'm fine with this patch being dropped if it would lead to any complications. Though I still think it makes sense to merge in the change to the README file, since I was able to download the extension (via Git) and use it fine, with SMW not installed.

mwjames commented 9 years ago

Though I still think it makes sense to merge in the change to the README file, since I was able to download the extension (via Git)

This should be true for 1.0.0 but starting with https://github.com/SemanticMediaWiki/SemanticSignup/commit/f3b0f163781fdedcb4c9d2c4ccb49a0c711a0ff2 we rely on the PSR-4 autoloader to invoke the classes.

JeroenDeDauw commented 9 years ago

This should be true for 1.0.0 but starting with f3b0f16

Oh... I thought we had done that already before 1.0.