search

SemanticMediaWiki / SemanticSignup

Allows adding additional fields to the user registration form, which get placed on the new users' user page, as well as stored semantically.
https://www.mediawiki.org/wiki/Extension:SemanticSignup
Other
6 stars 3 forks source link

Issue rendering signup form #9

Closed toniher closed 9 years ago

toniher commented 9 years ago

In UserFieldsCreateTemplate.php execute method the following code:

            if ( !$this->haveData( 'header' ) ) {
                  return '';
            }

prevents form to be drawn. If commented, everything OK. However, I noticed that Javascript checks (such as mandatory acting on empty fields) do not seem to work, so something should be included to make it happen. Any idea is appreciated.

mwjames commented 9 years ago

Maybe try @$this->haveData( 'header' ) === false in order to prevent $this->html( 'header' ) from accessing a non-existing header.

I noticed that Javascript checks (such as mandatory acting on empty fields) do not seem to work, so something should be included to make it happen. Any idea is

JavaScript from SF? Try loading/register the SF resourcemodule with this template. (maybe something like $this->getSkin()->getOutput()->addModules( ... );

toniher commented 9 years ago

Sorry not reading fully your comment first. I just submitted pull request https://github.com/SemanticMediaWiki/SemanticSignup/pull/10. I cannot access Skin object from $this, so I had to use global $wgOut :/. I removed header reference as well.

mwjames commented 9 years ago

Once you get this rolling maybe you could make one or two screen-dumps (see SG or SIL) as it will be easier for users to actually anticipate what this extension can do.

toniher commented 9 years ago

No problem. Right now extension is a bit spartan, and a next step would be offering a better look and options such as 'password by email' (as it's the case with default signup)

semantic-signup

mwjames commented 9 years ago

The screen-dump has been added to smw.org@SES

Right now extension is a bit spartan, and a next step would be offering a better look and options such as 'password by email' (as it's the case with default signup)

Maybe it is best to convert those items into follow-ups.

kghbln commented 9 years ago

follow-up for "password by email": see issue https://github.com/SemanticMediaWiki/SemanticSignup/issues/15