search

SemanticMediaWiki / SemanticTasks

Provides email task notifications and reminders
https://www.mediawiki.org/wiki/Extension:Semantic_Tasks
GNU General Public License v2.0
7 stars 6 forks source link

[WIP] Add Tests and turn SemanticTasksMailer into normal class #13

Closed PeterTheOne closed 5 years ago

PeterTheOne commented 5 years ago

This PR is made in reference to: #5 and #7

This PR addresses:

SemanticTasksMailer should be turned into a normal "class" without statics and split the class into something more testable (e.g. \SemanticTasks\UserMailer injecting the UserMailer, \SemanticTasks\Assignees etc.)

I'm not sure if I setup the travis part correctly.

When trying to test SemanticTasksMailer::generateDiffBodyTxt I get an Wikimedia\Rdbms\DBConnectionError: Cannot access the database: Unknown error (127.0.0.1) error in my MediaWiki-Vagrant setup.

YOUR1 commented 5 years ago

This seems like a huge refactor. Any ETA?