search

SemanticMediaWiki / WhatsNearby

Provides geolocation information to templates
Other
4 stars 3 forks source link

Make WhatsNearby work with Maps 6.x and 7.x #20

Closed kghbln closed 5 years ago

kghbln commented 5 years ago

@mwjames I assume that this extension also works with Maps 6.x and 7.x

@JeroenDeDauw FYI

mwjames commented 5 years ago

I assume that this extension also works with Maps 6.x and 7.x

Let's assume this. I haven't changed anything and assuming the interfaces remained as they were, it should work.

JeroenDeDauw commented 5 years ago

Won't work with latest Maps. For instance this static function no longer exists https://github.com/SemanticMediaWiki/WhatsNearby/blob/master/src/NearbyParserFunction.php#L125

assuming the interfaces remained as they were

Most of the Maps PHP code has been rewritten since 5.x. Nearly all of it is clean and shiny now. Might need to add some extension points back in again though.

JeroenDeDauw commented 5 years ago

I had a quick look at some stuff (including JS) and the linked static function usage is the only break I saw.

Though there also is the bit where Maps no longer supports OpenLayers.

kghbln commented 5 years ago

I had a quick look at some stuff (including JS) and the linked static function usage is the only break I saw.

So this line should just be removed?

JeroenDeDauw commented 5 years ago

As far as I can tell, that linked code in this extension is poking Maps so it loads some javascript that it needs. If that is no longer done, then I expect this extension to break.

JeroenDeDauw commented 5 years ago

I'll have a look at this. @kghbln I suggest you just disable whatsnearby on SMW server till this is resolved

JeroenDeDauw commented 5 years ago

https://github.com/SemanticMediaWiki/WhatsNearby/pull/22