search

SemanticMediaWiki / WhatsNearby

Provides geolocation information to templates
Other
4 stars 3 forks source link

Match changes in Maps 7.2 #22

Closed JeroenDeDauw closed 4 years ago

JeroenDeDauw commented 5 years ago

Includes bump of PHP version since Maps 7.2 requires 7.1, so not bumping it helps no one.

JeroenDeDauw commented 5 years ago

I have not tested this since right now I don't have the time to install this

kghbln commented 5 years ago

@JeroenDeDauw Currently I have no time to do a field test so I rather leave this to the code review of @mwjames to move forward here.

Note, Composer now upgraded to 7.1.0 instead of 7.2.0. I have no clue which other extension is now getting in the way.

JeroenDeDauw commented 5 years ago

PHP Fatal error: Declaration of MediaWikiPHPUnitCommand::createRunner() must be compatible with PHPUnit\TextUI\Command::createRunner(): PHPUnit\TextUI\TestRunner in /home/travis/build/SemanticMediaWiki/mw/tests/phpunit/MediaWikiPHPUnitCommand.php on line 3

JeroenDeDauw commented 5 years ago

Note, Composer now upgraded to 7.1.0 instead of 7.2.0. I have no clue which other extension is now getting in the way.

That is caused by the GitHub extension. I will update it. You can already install Maps ~7.1 though :)

kghbln commented 5 years ago

That is caused by the GitHub extension. I will update it. You can already install Maps ~7.1 though :)

Cool. Once this is fixed the wiki will automatically pull in the new versions. As for this extension I guess there is something in the pipeline. Once fluffed, give me a ping for me to add it to the "composer.local.json" file again for installation.

JeroenDeDauw commented 5 years ago

To clarify: I am not planning on poking more at this extension. The changes I provided might fix compat with maps fully, and if not, provide a good starting point.

kghbln commented 5 years ago

To clarify: I am not planning on poking more at this extension. The changes I provided might fix compat with maps fully, and if not, provide a good starting point.

No worries. I just fully depend on either of you here. I myself cannot fluff for known reasons. :)