search

Sematre / typst-letter-pro

DIN 5008 letter template for Typst
https://typst.app/universe/package/letter-pro/
MIT License
68 stars 2 forks source link

Page numbering hardcoded in English #7

Open Khoulaiz opened 2 months ago

Khoulaiz commented 2 months ago
  1. Create a letter with more than 1 page

Expected: For a DIN Letter I would expect a German numbering scheme

Actual: Numbering is using "Page 1 of 2"

Sematre commented 2 months ago

English is just the default. You can change it to German like this:

#show: letter-simple.with(
  // [...]
  page-numbering: (current-page, page-count) => [Seite #current-page von #page-count],
)
Khoulaiz commented 1 month ago

I know that I can change it. But why is English the default for a Letter following the German DIN standard? Everything else in this letter is in German. Sorry, but this doesn't make sense for me.

Sematre commented 1 month ago

The page numbering is the only place where in this library where there is a default English text. Everything else in this library is language independent.

Even tho this letter is following a German standard, documents written in Typst default to the English language. This is why I think it is the best choice to make English the default.

A good compromise could be to use the linguify library that can derive the correct translation from the document context. Would this work for you?