SemmieDev / Disc-Jockey

Play note block songs in Minecraft
MIT License
11 stars 1 forks source link

Add numerous new features to Disc Jockey #9

Closed EnderKill98 closed 1 year ago

EnderKill98 commented 1 year ago

Sorry for making this a massive PR. But I have been really enjoying and using this mod for the past months. I made a number of changes to improve the ability to have my janky mod interact with this mod.

See the commit descriptions for some extensive change lists (one commit in particular has a long list explaining many changes). Splitting those into separate commits seemed a bit hard since some improvements built on top of another already.

Main Improvements:

Demo Video: https://youtu.be/6kkZ3uCu3fU

Demo Video of integrating with a Bot I made (in my private janky "Hello Fabric" mod, I have not gotten to make it standalone yet sadly): https://youtu.be/ckdGRffeSg8 Many performance improvements (like async playback) were made because I ran my "bot" on a low power server with cpu rendering which made the client tps very unreliable and playback always sounded off because of that.

As said, I did these changes a long time ago and kept updating the base over it. I re-applied the changes here to make it work better. For the original commits, see the "1.X-modifications" branches on my fork.

It took me really long to find this mod, but once I did it was a game changer! <3

Edit: Btw the Mod can also be heard playing in this Video: https://youtu.be/3HSnDsfkJT8 (sometimes the notes were a bot off since the bot was online for 1-2 weeks then and was beginning lagging extremely hard, either mcs, javas fault or i still had a memory leak in my mod then). The Bot is still on that server btw.

SemmieDev commented 1 year ago

Hey, thanks for the pull request. I checked what you did, and it all looks good!