search

SempaiGames / haxe-ga

GoogleAnalytics Client API port to Haxe
Other
60 stars 23 forks source link

Event and User-Agent reporting fixes, utmvid parameter support #1

Closed goshki closed 11 years ago

goshki commented 11 years ago

Hi there,

I've fixed some issues with event reporting (some "null" strings were attached and category/action/label values were mixed up). I've also fixed User-Agent reporting and added utmvid (Unique visitor ID) support.

fbricker commented 11 years ago

Hi, thanks for the contribution! I'll upgrade the haxe-ga library on haxelib soon :)

Best, Federico

goshki commented 11 years ago

Great! :D If I happen to add any other features, would you like them in the master branch or specific feature-branches?

fbricker commented 11 years ago

If it adds nice features keeping back-compatibility, then I prefer to add them on the master branch. Also, someone told me Event's tracking (not page-tracking) is not fully working. As I don't track events on my projects (i track pages) I didn't find the time to test it right. If you can take a look at that it'll be nice also :+1:

goshki commented 11 years ago

As far as I have tested, the changes I've applied fix event reporting. But if some error still occurs, I'll be glad to take a look at it.

fbricker commented 11 years ago

Great! I'll tell people asking for that it's fixed now and advise to test it first just in case.

Thx!

fbricker commented 11 years ago

Hi, I just updated the library on haxelib (check http://lib.haxe.org/legacy/p/haxe-ga).

goshki commented 11 years ago

Great! :D