search

SempaiGames / haxe-ga

GoogleAnalytics Client API port to Haxe
Other
60 stars 23 forks source link

openfl 3 compilation fix (for native targets) #14

Closed eliasku closed 9 years ago

eliasku commented 9 years ago

there is no support for these info in openfl 3 anymore, actually we can discuss and check major version of openfl and make more tricky checks for preprocessor... Or the simplest solution is just drop that functionality from haxe-ga, and provide some customPackage setter outside of main module.

https://github.com/fbricker/haxe-ga/issues/13

fbricker commented 9 years ago

Hi, this is strange. Are you using OpenFL next or OpenFL legacy? We're using openfl 3.1.0 and this works (but we're compiling with openfl legacy, since next is still in beta and have things missing).

Anyway, if you can add this case to the pull request, I can merge it and upload a new version.

It'll look something like this (not 100% sure, please test it before commiting :) 

        #if (openfl && !flash && !html5 && !openfl-next)
        version+="/" + Lib.packageName + "." + Lib.version;
        #end

Thanks!

eliasku commented 9 years ago

Yeah, in openfl-legacy all is working, but we're not using much of openfl, so we're planning to migrate to openfl-next soon.

I've checked openfl-next define, and we totally can use it! I'll re-create the PR.

Thank you!