search

Semro / syncwatch

Browser extension to watch videos together
MIT License
135 stars 19 forks source link

Firefox does not support "incognito": "split" #10

Closed Semro closed 3 years ago

Semro commented 3 years ago

Added "incognito": "split" only in Chrome and Opera versions. Issue #9

CanYouJustWorkPlease commented 3 years ago

For Firefox it works out of the box the way it is, just gotta enable Sync Watch to run in Private mode. I just tested it out.

Semro commented 3 years ago

I have this error, loading it as a temporary add-on. image And it's mentioned in MDN that split setting is not supported by Firefox: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/incognito

CanYouJustWorkPlease commented 3 years ago

What I meant to say is the Sync Watch Firefox addon works fine for both normal mode and private mode, without having to add something like we added to Chrome, like "incognito": "split". So Sync Watch version 0.324 Firefox addon works well for both modes already.

Isn't version 0.324 working fine for you, for both modes, in Firefox?

CanYouJustWorkPlease commented 3 years ago

Oh, Firefox also has "incognito": "split", I didn't know about that. But version 0.324 works fine without it, I don't know why, but it works.

Semro commented 3 years ago

Yes, Firefox working fine with 0.324 version. Now I need to split manifest file between Chrome and Firefox. So, I just keep that issue open as a reminder.

Semro commented 3 years ago

Now manifest splitting in CI workflow It removes "incognito": "split", line for Firefox manifest.