search

Semro / syncwatch

Browser extension to watch videos together
MIT License
135 stars 19 forks source link

Sync playbackRate between users #37

Open apmforgitissues012 opened 1 year ago

apmforgitissues012 commented 1 year ago

Hello, thank you for maintaining this extension. I prefer to watch videos at higher speeds, It would be convenient if the current video speed was synchronized between users.

The speed is normally stored in "document.querySelector('video').playbackRate"
Implementing this features should be as easy as watching for a change and then setting the other client to the same speed.

Thank you for your time.

apmforgitissues012 commented 1 year ago

Appologies, I see you're setting the plackbackRate here: https://github.com/Semro/syncwatch/blob/master/plugin/js/content.js#L144-L148

This seems to work as long as the playback rate is set through the video player's ui, If an extension like Global Speed is used than the rate does not sync. Idealy, one client would have global speed disabled, and the other would overide the speed.