Semx11 / Autotip

A Forge modification that tips boosters and other users in gamemodes without an active booster.
https://autotip.pro/
MIT License
32 stars 17 forks source link

That player is not online, try another user! #33

Open TheDGOfficial opened 1 year ago

TheDGOfficial commented 1 year ago

After upgrading from 3.0.1 to 3.1.1 I started to get error "That player is not online, try another user!" (not a Java exception or such, error message from Hypixel), im assuming the mod is trying to tip someone offline. Wanted to check what changed between those versions in the source but I think the source code here is not up-to-date? Anyways I used Bytecode Viewer and it seems like the users to tip are fetched from server so mod version shouldn't matter? I don't know why it wasn't happening on the old version though, did i just get unlucky and the server started to send offline players to tip right after i upgrade making it look like it was caused by update? Not sure, I might try old version again later (I had a backup just in case).

TheDGOfficial commented 1 year ago

Might be a Hypixel side change I have no idea, I also started getting spammed by "You've already tipped someone in the past hour in \<game>! Wait a bit and try again!" messages.

Edit: Just realized my config value for the messages option got reset, I had it set to SHOWN, but it reverted to the default of COMPACT i think. I saw a check to migrate old config location from mods dir to config dir in the code, so not sure why it didn't work? Probably cause I'm not on Windows I guess, my file system is case sensitive and it sometimes causes issues with certain mods. Anyways I think latest source being published here would be good still and perhaps the config migration code needs to be looked at.

Will update if these errors still show up after switching to SHOWN option for messages, otherwise I will close it.

TheDGOfficial commented 1 year ago

The messages still show still even after changing the message option to one i used on the older version. There was also another error saying can't connect to the api (session servers down)? or something. This new version is so unrealiable, i had used the 3.0.1 for years i think without any issue. I didn't even notice there was a new version till i checked today since i was updating my mods (all were up to date other than autotip though so its not caused by other mod updates), i guess i will revert to the older version for now, at least till the latest source code is pushed to GitHub so i can do a compare view and investigate what might've caused all those issues.