search

Send-Tribute / tribute-dashboard

Abstraction UI layer for programmable interest smart contracts
https://app.sendtribute.io/
MIT License
5 stars 2 forks source link

Add tabs & contracts #7

Closed pi0neerpat closed 5 years ago

pi0neerpat commented 5 years ago

Tabs

Tabs can be managed in /src/dashboard/helpers/general.js

Context

Currently, if the ethers.js fails to load, context is never intialized with the user's wallet address, etc.

We can set a default context, however I think we should build without requiring context to load properly. e.g., app works even when context is undefined.

Contracts

I imported the rToken contracts from the repo. Now, if you want to update the contracts that ethers.js will use:

  1. cd rToken-contracts & git pull
  2. npm update-contracts in the root directory

Other

pi0neerpat commented 5 years ago

image

ejwessel commented 5 years ago

We should also limit the areas where context is used. If its displaying data then it should import the usage of context. I think there were a few general places where I saw it being used and it didn't need to be used.

pi0neerpat commented 5 years ago

I imported the rToken contracts from the repo.

Use a git submodule or see if they have turned it into a package that can be imported.

I am going to skip this for now, since I've made a card for it in Trello.

pi0neerpat commented 5 years ago

We should also limit the areas where context is used. If its displaying data then it should import the usage of context. I think there were a few general places where I saw it being used and it didn't need to be used.

Once we get ESLint set up, this will identify all the unused variables. I'm not going to hunt for them manually.

brianwchou commented 5 years ago

I changed the DAI abi address 

from: 0xbF7A7169562078c96f0eC1A8aFD6aE50f12e5A99
to: 0xC4375B7De8af5a38a93548eb8453a498222C4fF2

the previous one thats listed in the rToken readme doesnt have an ABI on etherscan. I think this should be fine since all we need is to approve