search

Sendouc / sendou.ink

Competitive Splatoon Platform
https://sendou.ink
GNU General Public License v3.0
227 stars 71 forks source link

Add recycled brella damage #1719

Closed AKonicki26 closed 3 months ago

AKonicki26 commented 3 months ago

Adds damage calculations for the recycled Brella to the object damage table. The name of the brella as well as the damage calculations are taken from @lobotomysyndrome on discord as of 03/01/2024.

(Closing the first PR and creating this one to squash commits)

Sendouc commented 3 months ago

Hey there. This object-dmg.json should be generated by the create-object-dmg-json.ts script and not be modified by hand. So from a quick look I think what is missing is that either:

1) Adjust the script generating the json so that it generates it in correct shape without manual adjustments 2) Change the object dmg calc code so that it reads splat brella multipliers for recycled.

Probably 1) is better

AKonicki26 commented 3 months ago

Done! Wasn't aware that those builders existed. Thank you much for the feedback! I'm not sure if it's possible to be doing the checks without the hardcoded values in there, but based on the way that they're already used in a few places, I don't believe its a bad idea here

Sendouc commented 3 months ago

Hmm I don't still get the same json generated by the command. Run the command (npx tsx scripts/create-object-dmg-json.ts) to generate the json then compare the one in the scripts/output folder to the one you have commited here. They seem different 🤔

Sendouc commented 3 months ago

Ok nm my bad checked something wrong. Yep this looks good! Thanks for the contribution :)