search

Sendouc / sendou.ink

Competitive Splatoon Platform
https://sendou.ink
GNU General Public License v3.0
227 stars 71 forks source link

Added open graph tags for tournaments #1736

Closed KaiserOfNone closed 2 months ago

KaiserOfNone commented 2 months ago

Here are a couple of screenshots of it working :D

Screenshot 2024-05-22 at 12 35 50 PM

image

Sendouc commented 2 months ago

Hey as mentioned this looks great! Very nice to have those good looking links on Discord.

One thing is that I believe this should be added to the to.$id.tsx meta object! This way it applies to all tournament pages such as brackets page.

In addition to.id route already loads the tournament data in loader so then we don't need to add any extra work to the backend. With this current solution due to how Remix works when they hit /register page the backend will resolve two times the tournament data object which is unnecessary.

Link: https://github.com/Sendouc/sendou.ink/blob/rewrite/app/features/tournament/routes/to.%24id.tsx#L39

KaiserOfNone commented 2 months ago

Done, now all to/$id routes have it.

Screenshot 2024-05-22 at 5 05 35 PM
Sendouc commented 2 months ago

🚀