search

Sendouc / sendou.ink

Competitive Splatoon Platform
https://sendou.ink
GNU General Public License v3.0
225 stars 72 forks source link

Add "looking for individual coaching" and "looking for scrim partners" options #1775

Closed ximk closed 1 week ago

ximk commented 2 weeks ago

Very simple change, just adds a new LFG type.

Addresses #1769.

ximk commented 2 weeks ago

@Sendouc Can you look into why this typecheck is failing? I've been searching for possible reasons for a bit and can't come up with a fix.

Sendouc commented 2 weeks ago

You need to modify the LFGType as defined in tables.ts :)

I would also get rid of this redundant constant on the file you modified. It should use the defined right under LFGType instead (LFG_TYPES)

ximk commented 2 weeks ago

This new error should be easier to fix, however I am lost again. 😅

ximk commented 2 weeks ago

Typecheck now passes thanks to @cysabi. :)

ximk commented 1 week ago

I'm going to add a "Looking for scrim partner" option as well, as I think that would be useful.

Sendouc commented 1 week ago

Cool! I like that "looking for scrim partners" as well