search

Sendouc / sendou.ink

Competitive Splatoon Platform
https://sendou.ink
GNU General Public License v3.0
225 stars 72 forks source link

Serbia flag invisible on profile #1777

Open Sendouc opened 1 week ago

Sendouc commented 1 week ago
image image

Why?

https://discord.com/channels/299182152161951744/1255085043664027689

ximk commented 1 week ago

It looks like the Serbian flag was never added in flags.css, maybe that's the issue? image

Sendouc commented 1 week ago

Hmm is it possible to check if it's just Serbia or are there other missing from countries-list NPM package? Interesting though

ximk commented 1 week ago

I found South Sudan was also missing it's flag by just clicking through countries and seeing if their flags appear on the user page. I don't know if there's a better way to check outside of going through the two-letter codes and seeing if they appear in flags.css.

Sendouc commented 1 week ago

I think maybe some small script might be the most fool proof way.

ximk commented 1 week ago

Just confirmed that is the issue. I added it myself locally, and this is the result: image

ximk commented 1 week ago

Should I just PR the fix with the Serbian flag, or do you want to wait to find them all (and add them) before PRing?

Sendouc commented 1 week ago

Maybe it's better just to do it all in go? Otherwise we just replace one issue with another.