search

Seneca-CDOT / my-photohub

Making it easy to share your photos using GitHub Pages
BSD 2-Clause "Simplified" License
14 stars 13 forks source link

Integration `github-upload` with the rest of the app #35

Open batunpc opened 1 year ago

batunpc commented 1 year ago

Fixes https://github.com/humphd/my-photohub/issues/33

As discussed in the issue, current behavior of the app is completely isolated from github-upload function using Octokit. Which was implemented at https://github.com/humphd/my-photohub/pull/11

This PR integrates the "upload images to authenticated repo using github-upload" functionality into the front-end, as it was programmatically written for client side.

Steps to reproduce

  1. First create an public repository with the desired name.

  2. Next, navigate to Settings > Developer settings > PAT > Tokens(Classic) to create a brand-new token. Ensure you have provided PAT permission to the created repository from step 1.

  3. After token is created you can start the app with npm run start and follow the rest of the steps. After you have uploaded an supported type image and click on upload, you will see raw directory within the repo you have created. It will look something like this.

batunpc commented 1 year ago

Thank you for your comments @humphd please let me know if I should do any other change for this PR

I have filed follow-up issue regarding your comment, and will be raising PR soon.

batunpc commented 1 year ago

Thank you @humphd I have implemented the suggested change 👍