search

Seneca-CDOT / telescope

A tool for tracking blogs in orbit around Seneca's open source involvement
https://telescope.cdot.systems
BSD 2-Clause "Simplified" License
96 stars 189 forks source link

Remove Feed related code from Posts Service #1907

Open humphd opened 3 years ago

humphd commented 3 years ago

In #1838 we are adding a Posts Service, and it's reusing code for Redis that currently deals with both Feeds and Posts. We can strip the Feeds logic out of there, and move it to #1828. See, for example: src/api/posts/src/storage.js

humphd commented 3 years ago

Somewhat related, we'll have to figure out if the logic for adding posts needs to stay there, or get moved out to another service too. See #1865.

HyperTHD commented 3 years ago

I assume this would involve the post parsing service (#1828) since that service will use parts with both feed and posts

sirinoks commented 2 years ago

@humphd Is this still a problem?

humphd commented 2 years ago

Given that feeds will live in Supabase, we should probably remove this, yes. It's still needed.

aserputov commented 2 years ago

Related to supabase.

humphd commented 2 years ago

We should figure out what is actually calling the feeds route. I suspect it's the old parser, which is going away. The new parser can talk directly to Supabase (cc @TueeNguyen).

HyperTHD commented 2 years ago

You have to also change the relationship between a feed and a post. Right now, a post must have a feed, so the frontend cannot load any posts that doesn't have a feed, which is why I didn't remove the feed related code when I made this service. I don't remember if the feeds routes were needed, probably not, but the feed class and methods used there definitely are atm, so you have to consider how to update that with supabase without incurring any sort of crash on the frontend due to missing required information @TueeNguyen

humphd commented 2 years ago

This can happen post-3.0