Open humphd opened 3 years ago
I can take this issue @humphd
Fixing this terminus issue to help solve this issue.
"This code here https://github.com/Seneca-CDOT/telescope/blob/master/src/api/status/src/server.js#L75-L83 and https://github.com/Seneca-CDOT/telescope/blob/master/src/api/status/src/services.js could get migrated into the client-side of the status page." - David Humphrey
Writing this here to document it so I don't lose it as I go down the rabbit hole!
We're landing support for this in Satellite with https://github.com/Seneca-CDOT/satellite/pull/48, so we can move forward on this as soon as ship an update.
@tpmai22, this might have been fixed in #3233. Could you test that this is the case? I guess that you'd have to go to GitPod and check that the error is still there. If it is not, let us know.
When I try to run on GitPod, I get this CORS error:
The problem comes from our microservice base, Satellite. Here we define healthchecks as part of using Terminus:
https://github.com/Seneca-CDOT/satellite/blob/d42a831a8ca6666dd5759eeccdbe932fe34239ca/src/satellite.js#L20
It would be great if we could add CORS to these as well.