Seneca-ICTOER / Intro2C

Seneca College IPC144 Course Notes
https://ipc144.sdds.ca
Other
7 stars 50 forks source link

chore: Upgrade Docusaurus and related library versions #176

Closed ghost closed 1 year ago

ghost commented 1 year ago

What does this PR do?

Tested with both local development and build - serve

closes #175

ghost commented 1 year ago

They do pin the following:

but they do not pin:

It seems that they do correlated releases of the @docusaurus namespaced libs (they all have the same, 2.2.0 version)

warning " > file-loader@6.2.0" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".

File-loader should be (and is) required by @docusaurus/core. with the appropriate version. Adding this dependency again into the package.json file caused the warning (with no other effect). Since the newly built version does not contain this dependency in the package.json, I think it can safely be removed (causing no change other than removing this error)

warning " > url-loader@4.1.1" has unmet peer dependency "webpack@^4.0.0 || ^5.0.0".

Exact same as above

warning "@docusaurus/core > react-loadable-ssr-addon-v5-slorber@1.0.1" has unmet peer dependency "react-loadable@*".

This warning is present in a freshly deployed install too. They seem to resolve react-loadable from @docusaurus/react-loadable but it triggers this warning non the less, I think this is expacted behaviour.

warning "@docusaurus/core > react-dev-utils > fork-ts-checker-webpack-plugin@6.5.2" has unmet peer dependency "typescript@>= 2.7".

This warning is also present in a fresh deploy, I'd guess this only has an impact if custom components are employed, and they are developed in TS.

warning "@docusaurus/plugin-ideal-image > @endiliey/react-ideal-image@0.0.11" has unmet peer dependency "prop-types@>=15".

I'm not exactly sure that this plugin is in use at all. If it is, it is being run on autopilot. Regardless, adding prop-types would only make sense for custom (non-TS) react components, so I'm not sure if in our case this peer-dep declaration makes sense. May be worth an investigation ticket if this lib is in use at all or not.

warning "@docusaurus/preset-classic > @docusaurus/theme-search-algolia > @docsearch/react > @algolia/autocomplete-preset-algolia@1.7.2" has unmet peer dependency "@algolia/client-search@>= 4.9.1 < 6"

This is also present in a fresh install, Seems to be an internal issue to the @algolia project, but it is indeed required by multiple other @algolia scoped package with the correct version

humphd commented 1 year ago

@CameronGray1210 this looks good to go from my perspective, but I'll let you have the final say and merge when you're happy.

CameronGray1210 commented 1 year ago

Yes this is greatly appreciated excellent resolution!